Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #16129 Rename tlp.modal to createModal
    Actions
    Infos
    #16129
    Joris MASSON (jmasson)
    2020-07-24 18:21
    2020-07-21 17:40
    17390
    Details
    Rename tlp.modal to createModal

    tlp.modal() is not very practical. The name "modal" is often used to identify a modal instance, but the import conflicts with this usage, forcing people to most of the time rename the import import { modal as createModal }. Now that all callers use webpack, it should be possible to rename that API.

    TLP
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson)
    Closed
    2020-07-24
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #14818 Tuleap Releases 11.18 Delivered 2020-08-26 09:01 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #16129

    Artifact Tracker v5

    request #16569 Javascript error on Labels tab in Project administration
    request #16686 Rename tlp.dropdown to createDropdown

    Git commit

    tuleap/tuleap/stable

    request #16129 Rename tlp.modal to createModal 3037dd8aa6
    User avatar Joris MASSON (jmasson) , 2020-07-24 11:02
    Merge 'gerrit #19587' into stable/master 0da0dd5d9a
    User avatar Thomas Gerbet (tgerbet) , 2020-07-24 11:51
    Rename tlp.modal to createModal f7335d94b7
    User avatar Joris MASSON (jmasson) , 2020-07-24 17:12
    Rename tlp.modal to createModal 3a4a9c0a3d
    User avatar Joris MASSON (jmasson) , 2020-07-24 17:22
    Rename tlp.modal to createModal 74c6a60056
    User avatar Joris MASSON (jmasson) , 2020-07-24 17:24
    Rename tlp.modal to createModal 5174261bae
    User avatar Joris MASSON (jmasson) , 2020-07-24 17:25
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2020-07-24 11:52
    Integrated into Tuleap 11.17.99.8.
    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2020-07-24