•  
      request #17931 Unit tests should pass with PHP 8.0
    Infos
    #17931
    Thomas Gerbet (tgerbet)
    2021-06-21 09:07
    2020-10-29 17:58
    19458
    Details
    Unit tests should pass with PHP 8.0
    PHP 8.0 release is approaching, it's time to start the movement on our side and start preparing the codebase to PHP 8.
    Dev tools
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2021-06-21
    Attachments
    Empty
    References
    Referencing request #17931

    Git commit

    tuleap/tuleap/stable

    Remove usage of XML_Security::enableExternalLoadOfEntities() in unit tests 3871a3fa87
    Do not enable processing of external entities when validating the schema of XML files 2cbea545c5
    Remove \XML_Security::loadFile() and \XML_Security::loadString() f94d13fedf
    Do not enable XML entities processing when exporting data 1d228406bf
    Do not enable XML entities processing when rendering WSDL content 48e0d47bc8
    TV3 to TV5 does not work anymore e38249f624
    Swagger specification file can be generated without notices 300b2d8ee8
    Do not allow to change XML external entities processing in the global scope 6cd1f2fd80
    Update willdurand/negotiation to 3.0 to get PHP 8.0 support 567747b347
    Fix hard crash when running the unit tests a4220fbd68
    Unit tests of Tuleap\Chart\Chart pass under PHP 8.0 360219679f
    Tuleap\Upload\FileBeingUploadedLocker works on PHP 8.0 4410661690
    Deal with the deprecation of the \openssl_pkey_free() function 54c9a754d2
    Custom session should not rely on a PHP warning 1b8bcd6ec2
    GraphOnTrackersV5_InSessionChartSorter works as expected on PHP 8.0 6e0e4f294d
    Tracker_FormElement_Field_List unit tests can be executed with PHP 8 d2b8c5aa84
    Artifact with a checkbox field cannot be updated 287942375d
    Update PHP-DI to 6.3.0 951cf9fa68

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-06-21 09:07
    • Status changed from Waiting for information to Closed
    • Close date set to 2021-06-21
    User avatar
    Thomas Gerbet (tgerbet)2021-01-04 14:39
    Implementation is on hold for now. The remaining failing tests need a more recent version of the lcobucci/jwt library which is only available for PHP 7.4. We will need to bump to PHP 7.4 first but we are blocked by request #18409.

    • Status changed from Under implementation to Waiting for information