Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #17964 Git lfs clone doesn't work without the .git extension
    Actions
    Infos
    #17964
    Lorentz Romain (lorentzr)
    2021-01-08 14:20
    2020-11-05 16:47
    19494
    Details
    Git lfs clone doesn't work without the .git extension
    Git lfs clone doesn't work without the .git extension with ssh.

    This work with git no lfs repository.
    SCM/Git
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Lorentz Romain (lorentzr)
    Declined
    Empty
    Attachments
    Artifact links
    Empty
    Empty
    References
    References list is empty
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-01-08 14:20
    Declining as this is not expected to change.
    • Status changed from Waiting for information to Declined
    User avatar
    Thomas Gerbet (tgerbet)2020-11-05 17:47
    Okay, it would have been nice to have the repro case in the description of the request but it was not obvious we were specifically talking about the git-lfs-authenticate SSH command.


    My first question still remains: how users ended up using such URLs? I'm a bit reluctant to introduces changes increasing the complexity in a sensitive area to accommodate something that is not a public behavior and that is not even tested somewhere in the codebase (as far as I can see).
    User avatar
    Martin GOYOT (goyotm)2020-11-05 17:29
    last edited by: Martin GOYOT (goyotm) 2020-11-05 17:31
    We are talking about this (plus my previous comment about the validity of different use cases):
    ~/t/git ❯❯❯ ssh gitolite@dev4mjagger git-lfs-authenticate use-me/refia.git download
    {"href":"https:\/\/tuleap-web.tuleap-aio-dev.docker\/plugins\/git\/use-me\/refia.git\/info\/lfs","expires_in":600,"header":{"Authorization":"RemoteAuth 1.874ee5e63a617d80957d4e0a46aaf8f98caef0fe6611ba104454a4d1ae17fe11"}}

    ~/t/git ❯❯❯ ssh gitolite@dev4mjagger git-lfs-authenticate use-me/refia download
    git-lfs-authenticate arg 1 must be a valid repository
    User avatar
    Martin GOYOT (goyotm)2020-11-05 17:18
    last edited by: Martin GOYOT (goyotm) 2020-11-05 17:19
    As of today:

    cloning with HTTP:
    - with .git with or without LFS ✅
    - without .git with or without LFS ✅

    cloning with SSH:
    - with .git with or without LFS ✅
    - without .git without LFS ✅
    - without .git with LFS 🛑

    I agree none of the URL does not contain the .git at the end. But for the sake of consistency, I would advocate either it works or it doesn't but not that it works in almost all cases but one.
    User avatar
    Thomas Gerbet (tgerbet)2020-11-05 16:53
    Hi,

    Why should it work? Was there a moment in when the URLs exposed by Tuleap to clone a repository did not contain .git at the end?
    • Status changed from Under implementation to Waiting for information