Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #17979 Replace $ui-color-* by $tlp-ui-*
    Actions
    Infos
    #17979
    Nicolas Terray (nterray)
    2020-11-18 11:59
    2020-11-10 16:44
    19509
    Details
    Replace $ui-color-* by $tlp-ui-*

    FlamingParrot defines its own set of colors via $ui-color-(danger|info|warning|success). However this definition is a duplicate from TLP counterparts ($tlp-ui-(danger|info|warning|success)).

    Having two different variables for the same color in Tuleap application is not nice since:

    • it duplicates the color value definition
    • it forces the developer to have a separate stylesheet (one for BP, one for FP) when such color must be used

    A first commit got rid of the first point by setting the value of $ui-color-* with $tlp-ui-*. See git #tuleap/stable/5dff416d27fe3d26d3485f48f4ec139a1dc26240 for details.

    The proposal is to remove all usage of $ui-color-* and use $tlp-ui-* instead.

    TLP
    development
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Nicolas Terray (nterray)
    Closed
    2020-11-18
    Attachments
    Empty
    References
    Referencing request #17979

    Git commit

    tuleap/tuleap/stable

    Merge 'gerrit #20769' into stable/master d84495e8ad
    User avatar Thomas Gerbet (tgerbet) , 2020-11-18 11:56
    request #17979: Replace $ui-color-* by $tlp-ui-* a9e9a379a7
    User avatar Nicolas Terray (nterray) , 2020-11-18 10:54
    request #17979: Replace $ui-color-* by $tlp-ui-* 5fcc53051e
    User avatar Nicolas Terray (nterray) , 2020-11-18 10:57
    Merge "request #17979: Replace $ui-color-* by $tlp-ui-*" 0d01b6582b
    User avatar Thomas Gerbet (tgerbet) , 2020-11-18 11:45
    Display settings

    Follow-ups