Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #19187 Clean the store of project creation
    Actions
    Infos
    #19187
    Marie Ange Garnier (marieange)
    2021-01-21 11:49
    2021-01-14 14:22
    20759
    Details
    Clean the store of project creation
    In order to communicate data between php and vue app, we tend to use the store everywhere.

    This properties are reactive (vue listen their update and react to their change).
    We do not need this as this elements are configuration data, let's move them inside a dedicated substore
    Other
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Marie Ange Garnier (marieange)
    Closed
    2021-01-21
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #18826 Tuleap Releases 12.5 Delivered 2021-10-02 17:12 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #19187

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/82/21382/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD e72dfa8683
    User avatar Lorentz Romain (lorentzr) , 2021-01-21 11:43
    request #19187 Clean the store of project creation a3452ba5e9
    User avatar Marie Ange Garnier (marieange) , 2021-01-19 11:27
    Referenced by request #19187

    Artifact Tracker v5

    rel #18826 12.5

    Other

    gerrit #21382
    Display settings

    Follow-ups

    User avatar
    Marie Ange Garnier (marieange)2021-01-14 16:42
    last edited by: Marie Ange Garnier (marieange) 2021-01-14 16:47
    The main issue is that we end with big store (example document store has 50 different keys).
    It makes the job of developer hard to find what he wants inside the store due to the number of keys.
    We had a discussion with team and choose the following way of resolving issue,
    configuration property (never updated in mutations/actions) are stored in a dedicated substore
    With this:
    - configuration values are still observable in vue dev tools
    - we can fold the configuration key and during development we can easily find what we need inside it
    I updated the issue to reflect what we decided
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    Thomas Gerbet (tgerbet)2021-01-14 14:56
    Hi,

    Can you please explain why we need this? What issues do we have with storing everything in the store?
    I'm not sure to see the benefits in changing that and at the very least it brings the inconvenient of not seeing those values in the Vue dev tools.