•  
      request #20062 Transform the artifact modal into a lib
    Infos
    #20062
    Joris MASSON (jmasson)
    2021-04-12 08:55
    2021-03-08 17:05
    21655
    Details
    Transform the artifact modal into a lib

    Part of the bigger request #18391 Migrate Tracker Artifact Modal out of AngularJS

    A lot of libs have already been extracted and with card-fields we should have the building blocks necessary to transform the artifact modal into an "internal npm" library. This brings several advantages:

    • Planning View, Kanban and Test Management are no longer responsible for building and aliasing dependencies of the artifact modal. It is built only once and then included as if it were any node_modules.
    • We no longer need to make sure things can be built with three different configurations (one for each caller)
    • We can "isolate" the modal's code behind a form of Interface (the AngularJS top-level module) and gradually modify its internal API to get rid of AngularJS

    The obvious downside is that now we must run twice npm run watch: once in the modal's folder and once in the calling app.

    The artifact modal has one more dependency that must also be transformed to a lib: codendi.Tooltip.

    Trackers
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson)
    Closed
    2021-04-12
    Attachments
    Empty
    References

    Follow-ups