Tuleap Community Edition development and releases are no longer public. You have until September 30th to download packages and sources in Tuleap project. You can contact the team if you need further assistance.

    •  
      request #20085 Root Makefile & shell function
    Infos
    #20085
    Matthieu Monnier (mmonnier)
    2021-03-15 15:27
    2021-03-14 21:42
    21690
    Details
    Root Makefile & shell function

    Hello Tuleap Team,

    Firstly, I would like to congratulate you for the great work! ;)

    Recently, I have worked with the setup environment with Docker Compose, and I noticed that the variable REALTIME_KEY was not defined:

    ...
    311     @echo "LDAP_MANAGER_PASSWORD=`env LC_CTYPE=C tr -dc 'a-zA-Z0-9' < /dev/urandom | head -c 32`" >> .env
    312     @echo VIRTUAL_HOST=tuleap-web.tuleap-aio-dev.docker >> .env
    313     @echo "REALTIME_KEY=$(head -c 64 /dev/urandom | base64 --wrap=88)" >> .env
    314
    ...
    

    The shell function is missing into the variable, but for consistency, the backquotes are most appropriate in my opinion:

    ...
    311     @echo "LDAP_MANAGER_PASSWORD=`env LC_CTYPE=C tr -dc 'a-zA-Z0-9' < /dev/urandom | head -c 32`" >> .env
    312     @echo VIRTUAL_HOST=tuleap-web.tuleap-aio-dev.docker >> .env
    313     @echo "REALTIME_KEY=`head -c 64 /dev/urandom | base64 --wrap=88`" >> .env
    314
    ...
    

    Thank you,

    Dev tools
    development
    EL7 (CentOS|RHEL)
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2021-03-15
    Attachments
    References
    Referenced by request #20085

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-03-15 15:27

    Integrated into Tuleap 12.6.99.100.


    • Status changed from Under review to Closed
    • Close date set to 2021-03-15
    User avatar
    Thomas Gerbet (tgerbet)2021-03-15 13:47

    Hi,

    Thanks for the patch, I uploaded it on Gerrit (gerrit #22108) and I will merge it once the CI is happy.

    On a side note, I took the liberty to update the mail address of your account to the one that was used in your patch file.


    • Status changed from New to Under review
    • Assigned to changed from None to Thomas Gerbet (tgerbet)
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes