Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #20095 Don't Repeat Ourselves with core assets
    Infos
    #20095
    Nicolas Terray (nterray)
    2021-03-17 09:31
    2021-03-17 08:36
    21695
    Details
    Don't Repeat Ourselves with core assets

    Everywhere in the codebase we can find:

    new \Tuleap\Layout\IncludeAssets(__DIR__ . '/../../../www/assets/core', '/assets/core')

    In order to avoid guessing what is the right path for assets/core (and to save few keystrokes), we propose to replace the previous instantiation with the following:

    new \Tuleap\Layout\IncludeCoreAssets()
    Empty
    All
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Nicolas Terray (nterray)
    Closed
    2021-03-17
    Attachments
    Empty
    References
    Referencing request #20095

    Git commit

    tuleap/tuleap/stable

    DRY core assets fed1e5f432
    User avatar Nicolas Terray (nterray) , 2021-03-17 08:46
    Referenced by request #20095

    Artifact

    rel #19325 12.7

    Other

    gerrit #22139
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-03-17 09:31

    Integrated into Tuleap 12.6.99.117.

    • Status changed from Under review to Closed
    • Connected artifacts
    • Close date set to 2021-03-17