Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #20109 Pullrequest reviewers REST endpoint can throw an unhandled exception
    Actions
    Infos
    #20109
    Yannis ROSSETTO (rossettoy)
    2021-08-21 10:24
    2021-03-19 15:36
    21702
    Details
    Pullrequest reviewers REST endpoint can throw an unhandled exception

    Given a private project, with a Git repository and a pullrequest. If I add a project member as a reviewer of the pullrequest, and then remove him/her as a project member, then the API endpoint pull_requests/:id/reviewers returns an error 500.

    Pull Request
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Yannis ROSSETTO (rossettoy)
    Under implementation
    Empty
    Attachments
    Artifact links
    Empty
    Empty
    References
    Referencing request #20109

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/89/22189/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 10fa961a69
    User avatar Lorentz Romain (lorentzr) , 2021-03-22 16:46
    request #20109 Pullrequest reviewers REST endpoint can throw an unhandled exception d6e5222397
    User avatar Yannis ROSSETTO (rossettoy) , 2021-03-19 16:07
    Referenced by request #20109

    Other

    gerrit #22189
    Display settings

    Follow-ups

    User avatar
    Yannis ROSSETTO (rossettoy)2021-08-21 10:24

    @lorentzr said in the review: "Display problem: user is added on reviewers tab even if the rest route returns an error. This disappear after reloading the page"

    This will be handled in a dedicated patch.

    • Status changed from Under review to Under implementation