•  
      request #21775 Favor PHPUnit mock system over Mockery - part 2
    Infos
    #21775
    Yannis ROSSETTO (rossettoy)
    2024-03-02 15:30
    2021-06-08 10:58
    23358
    Details
    Favor PHPUnit mock system over Mockery - part 2

    Following the work introduced by request #21326, this request will be here to log the work done on unit tests in plugins to use PHPUnit internal mock system instead of Mockery.

    Other
    All
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Empty
    Under implementation
    Empty
    Attachments
    Empty
    References
    Referencing request #21775

    Git commit

    tuleap/tuleap/stable

    [tech] Almost all GitLab unit tests do not use Mockery anymore d98ba8e7be
    [tech] Jira import unit tests are now checked by psalm 93a91ead38
    Finish to move away from Mockery in the GitLab plugin 12b7de6b5d
    tech: Do not use Mockery anymore in program management unit tests 3a797c7d68
    tech: Some Testplan unit tests do not use Mockery anymore c6a06385d1
    userlog and testplan plugins do not use Mockery anymore 4c9ddd60f5
    chore: Remove usage of Mockery 89b831c329
    chore: Decrease usage of Mockery 6b38e1c94f
    Explicitly opt-out plugins that cannot have their unit tests typechecked (yet) fe438c462d
    chore: Decrease usage of Mockery 9a808620f2
    chore: Decrease usage of Mockery 4c4048eae3
    chore: Decrease usage of Mockery 28f0f1b43b
    chore: Decrease usage of Mockery (December 2022) 598f7098d1
    chore: Webdav unit tests are now checked by psalm ed92f20346
    [tech] Do not use Mockery anymore in unit tests 15fe8dfdbc
    [tech] Do not use Mockery anymore in unit tests d652b4882c
    chore: Decrease usage of Mockery (December 2022) ee5038186e
    Drop usage of Mockery in Tuleap\GitLFS\Batch unit tests c1bef40a3c
    Drop usage of Mockery in InviteBuddy unit tests 64cc9179fc
    Drop usage of Mockery in Tuleap\GitLFS\Transfer and Tuleap\GitLFS\StreamFilter unit tests 64d7e79038
    Drop usage of Mockery in GitLFS unit tests 989da7219f
    Drop usage of Mockery in openidconnectclient plugin be9472c93e
    Drop usage of Mockery in velocity plugin edb8bfeeba
    Drop usage of Mockery in projectmilestones plugin ff6ab3761a
    chore: Decrease usage of Mockery (May 2023) cd4c59499f
    chore: run psalm on unit tests without Mockery 8ebbc5b34a
    hudson_git plugin does not use Mockery anymore 5ec1acdc0c
    chore: drop Mockery usage in Document plugin c4c80ff491
    chore: Drop Mockery in some core tests e5e38ef828
    chore: Drop Mockery usage in taskboard plugin e1c611c604
    chore: Drop Mockery usage in roadmap plugin b875eda2ca
    chore: Drop Mockery usage in LDAP plugin bc2c337375
    chore: Drop Mockery usage in some plugins 55e0c28bd3
    chore: Plugin projectmilestones unit tests are checked by psalm 2ed275d873
    chore: Drop Mockery usage in baseline plugin 3c0f873583
    chore: Drop Mockery usage in crosstracker plugin 5f8ffa1aa6
    chore: Drop Mockery usage in hudson plugin bf76e1313b
    chore: Drop Mockery usage in svn plugin 1155b143a4
    chore: Drop Mockery usage in pullrequest plugin de793e233b
    chore: Drop Mockery usage in DB core unit tests 2059ddfc95
    chore: Drop Mockery usage in Admin HelpDropdown 593ee2d4e1
    chore: Drop Mockery usage in some core tests 49c5855d6f
    chore: Drop Mockery usage in Kanban plugin 8944f060bf
    chore: Drop some Mockery usage in core tests 753a3554f8
    chore: Drop some Mockery usage in core tests 6cf326dd9b
    chore: Continue to drop some Mockery usage in tests 6479020a98
    chore: Continue to drop some Mockery usage in tests 83f0d6d4d8
    chore: Drop some Mockery usage in core tests 1a5c718682
    chore: Drop Mockery usage in Backend core tests af1bce6855
    chore: Drop Mockery usage in some Dashboard core tests 370115f44d
    chore: Drop some Mockery usage in tests acf2763c77
    chore: Drop Mockery usage in some Dashboard/Project core tests 0cf88e63ae
    chore: Drop some Mockery usage in tests 86b9a62521
    chore: Drop Mockery usage in date core tests 37781dd8c1
    chore: Drop Mockery usage in TV3 tests cb64abe326
    chore: Drop Mockery usage in event core tests c7b283cf51
    chore: Drop Mockery usage in Glyph core tests 66b5fcd896
    chore: Drop Mockery usage in HelpDropdown core tests 8988feaa17
    chore: Drop Mockery usage in Http core tests 03691a78b6
    chore: Drop Mockery usage in some Include core tests dc6a625630
    chore: Drop Mockery usage in some SystemEvents tests bae33e241e
    chore: Drop Mockery usage in some Include core tests 91c405a616
    Permissions of file SystemEvent_PROJECT_DELETE_Test are incorrect a5687dc1c5
    chore: Drop Mockery usage in Include core tests ebdc987b04
    chore: Drop Mockery usage in Jenkins core tests 62c8422e1f
    chore: Drop Mockery usage in JWT & Label core tests 70d922ad80
    chore: Drop Mockery usage in language core tests 38633b5009
    chore: Drop Mockery usage in Layout core tests 60d184ca1c
    chore: Drop Mockery usage in Log core tests bc5f1b677f
    chore: Drop Mockery usage in Mail core tests f70d8da686
    chore: Drop Mockery usage in Markdown and Password core tests df34ac6e25
    chore: Drop Mockery usage in some core tests f732a1a621
    chore: Drop Mockery usage in some Permission core tests e4c327b01c
    chore: Drop Mockery usage in some permission core tests 2d5364b7a1
    chore: Drop Mockery usage in permission core tests 3fc59bc4fb
    chore: Drop Mockery usage in Platform core tests 87b406a067
    chore: Drop Mockery usage in some Plugin core tests 9f71fdcbc3
    chore: Drop Mockery usage in Plugin core tests 224eb15bce
    chore: Drop Mockery usage in Project/Admin/Categories core tests 14497828d2
    chore: Drop Mockery usage in Project/Admin/DescriptionFields core tests c3299f3f48
    chore: Drop Mockery usage in some core tests 94fdcc78e1
    chore: Drop Mockery usage in some Project/Admin core tests 0fae85d9b9
    chore: Drop Mockery usage in some Project/Admin/ProjectUGroup core tests c14de33ca4
    chore: Drop Mockery usage in some Project/Admin/ProjectUGroup core tests 6d858afd7a
    chore: Drop Mockery usage in Project/Admin/ProjectUGroup core tests 86c27bc60b
    chore: Drop Mockery usage in some core tests bf9a72090c
    chore: Drop Mockery usage in Project/Admin/Routing core tests 0a8cdf0c1e
    chore: Drop Mockery usage in Project/Admin/Service core tests a3a26ec29e
    chore: Drop Mockery usage in SVNCore tests 7611e985fa
    chore: Drop Mockery usage in Request tests 3dfb8397c2
    chore: Drop Mockery usage in Project/Admin core tests fefe8e4e91
    chore: Drop Mockery usage in Project/Banner core tests b8e08cfb9e
    chore: Drop Mockery usage in Project/Hierarchy core tests b06093cf45
    chore: Drop Mockery usage in Project/ProjectBackground core tests fa6574f972
    chore: Drop Mockery usage in Project/ProjectDetails core tests e40d691c2c
    chore: Drop Mockery usage in Project/REST/v1 core tests 3d09dc7c45
    chore: Drop Mockery usage in some Project/REST core tests 373f595cfb
    chore: Drop Mockery usage in Project/REST core tests fea4e59d6f
    chore: Drop Mockery usage in Project/Service core tests 00bd08e897
    chore: Drop Mockery usage in Project/UGroups/Binding core tests 3bcfabfa73
    chore: Drop Mockery usage in some Project/UGroups core tests 194b84b0c3
    chore: Drop Mockery usage in Project/UGroups/Membership core tests 6e7ec4370a
    chore: Drop Mockery usage in Project/UGroups core tests 770408391a
    chore: Drop Mockery usage in Project/Webhook core tests 7de76b390f
    chore: Drop Mockery usage in Dashboard core tests 332a701aca
    chore: Drop Mockery usage in Project/XML core tests 230f30b435
    chore: Drop Mockery usage in some Project core tests 3d6a46304a
    chore: Drop Mockery usage in some Project core tests baf93ff992
    chore: Drop Mockery usage in some Project core tests b35e594ab9
    chore: Drop Mockery usage in some Project core tests 4ea87ff120
    chore: Drop some Mockery usage in agiledashboard plugin 3736c5719d
    Fix unit tests of the agile dashboard plugin under PHP 8.2 fcd526152e
    chore: Drop Mockery usage in some Project core tests f1ee143955
    chore: Drop Mockery usage in some Project core tests e50fb167d2
    chore: Drop Mockery usage in some Project core tests 340624f67a
    chore: Drop Mockery usage in some Project core tests 123f39382e
    chore: Drop Mockery usage in some Project core tests 529f8a21fd
    chore: Drop Mockery usage in some Project core tests df7d3ec43a
    chore: Drop Mockery usage in some Project core tests eede722564
    chore: Drop Mockery usage in some Project core tests 291075b5a1
    chore: Drop Mockery usage in some Project core tests c9eb1165cd
    chore: Drop Mockery usage in some Project core tests bf294d2959
    chore: Drop Mockery usage in Project core tests 3634452c2b
    chore: Drop Mockery usage in Queue core tests 391d481eeb
    chore: Drop Mockery usage in RealTime core tests df4481c528
    chore: Drop Mockery usage in Reference/ByNature/Forum core tests f74a25bdcf
    chore: Drop Mockery usage in Reference/ByNature/FRS core tests d81bc7d643
    chore: Drop Mockery usage in Reference/ByNature/News core tests 91399b4152
    chore: Drop Mockery usage in some Reference core tests 26d7e52d25
    chore: Drop Mockery usage in some Reference core tests 336a50b481
    chore: Drop Mockery usage in some Reference core tests 85a32674e7
    chore: Drop Mockery usage in Reference/Presenters core tests e593e30e77
    chore: Drop Mockery usage in Reference/ByNature core tests 13ecbf4027
    chore: Drop Mockery usage in Reference/ByNature/Wiki core tests 13d2034d88
    chore: Drop Mockery usage in TQL invalid query tests 505d4f62cb
    chore: Drop Mockery usage in Reference core tests 8aab5faf4d
    chore: Drop Mockery usage in Request core tests 2fa859d631
    chore: Drop Mockery usage in SVNCore core tests 463ab1fd67
    chore: Drop Mockery usage in some SystemEvent core tests 6c2eaccc09
    chore: Drop Mockery usage in SystemEvent core tests 1854fa286a
    chore: Drop Mockery usage in wiki core tests 7ccb0f2a4f
    chore: Drop Mockery usage in Redis core tests 7c83a8545f
    chore: Drop Mockery usage in core integration tests 33ad195ef0
    chore: Drop Mockery usage in AgileDashboard/ExplicitBacklog tests 209647f9fe
    Referenced by request #21775

    Other

    gerrit #22999
    gerrit #23016
    gerrit #23011
    gerrit #23027
    gerrit #24009
    gerrit #25045
    gerrit #25291
    gerrit #25552
    gerrit #25556
    gerrit #26008
    gerrit #26584
    gerrit #26744
    gerrit #27458
    gerrit #27457
    gerrit #27465
    gerrit #27946
    gerrit #27951
    gerrit #27964
    gerrit #27969
    gerrit #27977
    gerrit #27973
    gerrit #27975
    gerrit #28657
    gerrit #28671
    gerrit #28739
    gerrit #28858
    gerrit #28863
    gerrit #28872
    gerrit #28894
    gerrit #28900
    gerrit #28926
    gerrit #28927
    gerrit #28942
    gerrit #28946
    gerrit #28950
    gerrit #28969
    gerrit #29026
    gerrit #29045
    gerrit #29044
    gerrit #29068
    gerrit #29175
    gerrit #29178
    gerrit #29180
    gerrit #29182
    gerrit #29183
    gerrit #29195
    gerrit #29389
    gerrit #29542
    gerrit #29557
    gerrit #29590
    gerrit #29630
    gerrit #29759
    gerrit #29778
    gerrit #29784
    gerrit #29783
    gerrit #29790
    gerrit #29796
    gerrit #29797
    gerrit #29803
    gerrit #29809
    gerrit #29815
    gerrit #29820
    gerrit #29821
    gerrit #29841
    gerrit #29842
    gerrit #29846
    gerrit #29852
    gerrit #29854
    gerrit #29860
    gerrit #29868
    gerrit #29880
    gerrit #29892
    gerrit #29894
    gerrit #29903
    gerrit #29905
    gerrit #29909
    gerrit #29919
    gerrit #29925
    gerrit #29941
    gerrit #29944
    gerrit #29954
    gerrit #29962
    gerrit #29967
    gerrit #29968
    gerrit #29971
    gerrit #29977
    gerrit #29999
    gerrit #30000
    gerrit #30024
    gerrit #30034
    gerrit #30038
    gerrit #30039
    gerrit #30051
    gerrit #30054
    gerrit #30056
    gerrit #30069
    gerrit #30076
    gerrit #30080
    gerrit #30086
    gerrit #30100
    gerrit #30101
    gerrit #30107
    gerrit #30114
    gerrit #30116
    gerrit #30120
    gerrit #30129
    gerrit #30163
    gerrit #30186
    gerrit #30159
    gerrit #30218
    gerrit #30220
    gerrit #30222
    gerrit #30229
    gerrit #30242
    gerrit #30249
    gerrit #30262
    gerrit #30268
    gerrit #30276
    gerrit #30293
    gerrit #30305
    gerrit #30312
    gerrit #30332
    gerrit #30369
    gerrit #30365
    gerrit #30360
    gerrit #30359
    gerrit #30341
    gerrit #30422
    gerrit #30374
    gerrit #30558
    gerrit #30569

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2021-06-08 12:09

    gerrit #22999 integrated into Tuleap 12.9.99.110.

    To anyone: I expect to automate a large part of the migration with Rector so maybe hold until then before rewriting all the things by hand (it's less annoying to review the rules used to automate the migration than manual changes).