•  
      request #22231 Decrease adapter responsibility
    Infos
    #22231
    Marie Ange Garnier (marieange)
    2022-03-04 09:34
    2021-07-19 17:32
    23798
    Details
    Decrease adapter responsibility

    Some objects in adapter are performing code who is related to domain We should move it to domain namespace

    Program Management
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Marie Ange Garnier (marieange)
    Closed
    2022-03-04
    Attachments
    Empty
    References
    Referencing request #22231

    Git commit

    tuleap/tuleap/stable

    ProgramTrackerAdapater can be moved under Domain c8ddc5b756
    Introduce user identifier 43d5c82c5c
    Move PrioritizeFeaturesPermissionVerifier into Domain ead7f98ae0
    Remove dependency to PFUser in ProgramIncrementChanged f16be9ca92
    Use UserIdentifier in ProgramIdentifier 277446571f
    Remove PFUser from ProgramIncrementsRetriever 562687b79a
    Don't use ProjectUGroup in Program Management Domain 32b5a54b9f
    Add a proxy arround PFUser object in UserIdentifier a3627f2f6d
    Replace ToBeCreatedProgram by ProgramForAdministrationIdentifier f03f450e8e
    Move `test/unit` from `Tuleap\ProgramManagement\` to `Tuleap\ProgramManagement\Tests` namespace 3ad24c0a52
    Add a builder for ProgramIdentifier 3fd6fb8817
    refactoring: Build ArtifactLinkValue with a static method e788f7842d
    refactoring: Build TitleValue with a static method d3774d0d9e
    refactoring: Build DescriptionValue with a static method 46ec724f98
    Domain should not have dependency on UserProxy (Adapter) c0641b3a8e
    refactoring: Build StartDateValue with a static method dd7d1b2e60
    refactoring: Build EndPeriodValue with a static method d5e38d7a64
    refactoring: Introduce a Facade interface for field values 40056c5831
    refactoring: build MappedStatusValue with a static method d19cd05611
    refactoring: Build StatusValue with a static method ba69757fcd
    refactoring: remove ReplicationData::getFullChangeset 77bc41f2b2
    Remove external dependencies from `ProgramForAdministrationIdentifier` f4f8e781c1
    Remove PFUser dependency from BuildTeam a78a71b2c6
    Split CheckProgramIncrement interface 9dc3975a1f
    Remove PFUser from ProgramTracker 06ee4836e9
    Remove PFUser from ProjectManagerAdapter 54ed941b1e
    Remove PFUser from ReplicationData 40bcbe4864
    Remove PFUser from planning c8ce77f670
    Remove PFUser from PlanChange c7882771ec
    Remove PFUser from BuildPlanning 6dff2785f4
    Remove dead code `saveProgram` is never called f523a8e2f7
    In RetrieveIterationTracker replace primitve project_id by ProgramIdentifier 720ad56fb5
    Update ADR test examples 345f3ed6a1

    Follow-ups

    User avatar

    We no longer work on this subject. I'm closing the artifact, if we want to do more cleaning on plugin, we'll open new requests


    • Status changed from Under implementation to Closed
    • Close date set to 2022-03-04