Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #24188 Force multiline arrays and method/function declarations to have a trailing comma in the PHP codebase
    Actions
    Infos
    #24188
    Thomas Gerbet (tgerbet)
    2021-12-01 10:51
    2021-11-30 17:36
    25733
    Details
    Force multiline arrays and method/function declarations to have a trailing comma in the PHP codebase

    Recent versions of PHP allow for both cases so we have both cases in the codebase.

    We should settle on one and enforce it.

    I propose to go with the trailing commas because it generates cleaner diff and it is also what Prettier does with the arrays so it is more consistent with the frontend codebase.

    Other
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2021-12-01
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #23428 Tuleap Releases 13.3 Delivered 2021-12-08 17:17 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #24188

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/77/24577/4' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 55e11180a0
    User avatar Joris MASSON (jmasson) , 2021-12-01 10:49
    request #24188: Force multiline arrays and method/function declarations to have a trailing comma in the PHP codebase 7a8544134d
    User avatar Thomas Gerbet (tgerbet) , 2021-12-01 10:18
    Referenced by request #24188

    Artifact Tracker v5

    rel #23428 13.3

    Other

    gerrit #24577
    Display settings

    Follow-ups