•  
      request #26374 Stop exposing @tuleap/tlp-fetch module in tlp module
    Infos
    #26374
    Thomas Gerbet (tgerbet)
    2022-04-07 09:40
    2022-04-06 10:54
    27898
    Details
    Stop exposing @tuleap/tlp-fetch module in tlp module

    Originally tlp was conceived as a giant module available from everywhere, since then this giant module has been split in multiple small packages in order to be able to re-use some parts in specific contexts.

    As a result we end up with (at least) two ways to use the same code which can be confusing or even lead to bugs.

    We should have only one way to use this code and only keep the one that come with the less amount of magic. This means stop exposing @tuleap/tlp-fetch via the tlp module.

    Note that this means that the @tuleap/tlp-fetch code might be duplicated multiple times across apps in the same page. Thanks to the tree-shaking of our bundlers the size increase should be quite limited and it also means we stop loading on every pages code that we might not use. If this approach becomes problematic for other parts of the tlp module we can still probably deal with it in a more efficient way using things like module federation.

    Other
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2022-04-07
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Joris MASSON (jmasson)2022-04-07 09:40

    gerrit #25596 (Remove remaining indirect usages of @tuleap/tlp-fetch) integrated in Tuleap 13.7.99.90


    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2022-04-07