•  
      request #26386 Remove list-picker styles from all-purpose FlamingParrot / TLP themes
    Infos
    #26386
    Joris MASSON (jmasson)
    2022-04-22 10:42
    2022-04-11 17:56
    27915
    Details
    Remove list-picker styles from all-purpose FlamingParrot / TLP themes

    Ever since list-picker's first usage in Tuleap, most of its CSS rules have been scattered in FlamingParrot and TLP. Originally, this was due to the lack of CSS Custom properties. We didn't want to have to write 12 different stylesheets (because of colors and condensed mode), so the style rules just piggybacked on top of FlamingParrot general styles and in TLP. Not only it makes it very hard to find the styling rules and maintain them, but it also means they were copy-pasted and slightly tweaked in each case.

    We should put a stop to this and move all of the rules in list-picker's stylesheet. Nowadays, we are able to use CSS custom properties and most of the properties for colors are already exposed, so we no longer have this constraint and we can write the rules only once.

    UX/UI
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson)
    Closed
    2022-04-22
    Attachments
    Empty
    References

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2022-04-22 10:42

    gerrit #25749 (Fix list picker item highlighted style) integrated into Tuleap 13.7.99.207.


    • Status changed from Reopen to Closed
    • Close date set to 2022-04-22
    User avatar

    Reopened because ListPicker selected options style doesn't match badge style.

    gerrit #25745 integrated into Tuleap 13.7.99.204 fixes the square style. A last commit will fix the × button style.