Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #27896 Smart commit is not smart enough
    Actions
    Infos
    #27896
    Manuel Vacelet (vaceletm)
    2022-08-29 10:31
    2022-07-26 17:07
    29460
    Details
    Smart commit is not smart enough

    As you can see in https://tuleap.net/plugins/tracker/?aid=27894#followup_114614:

    • the first commit contains the "closes" and move the artifact to "Blocked" (first not Open value)
    • the second commit also contains "closes" but instead of realizing that we are already in a closed state, it tries to transition. On this tracker there is a workflow so from "Blocked" (first not open value) i can only move to sth else: the second not close state: "Invalid"

    Two things here:

    • when the artifact is already in a closed state, it should not move forward.
    • is that expected that the merge commit is evaluated before the commit itself ?
    SCM/Git
    13.11
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Closed
    2022-08-22
    Attachments
    Artifact links

    User stories

    Releases

    Reported in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #26753 Tuleap Releases 13.11 Delivered 2022-09-05 15:28 Manuel Vacelet (vaceletm)

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #26815 Tuleap Releases 14.0 Delivered 2022-10-12 09:57 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #27896

    Git commit

    tuleap/tuleap/stable

    fix(git): Post commit hook analyze commits in chronological order 1eeb4be5d0
    User avatar Manuel Vacelet (vaceletm) , 2022-07-28 17:04
    Phrases closing artifacts from a commit message should start with an uppercase letter and end with a dot 2f2ff1347a
    User avatar Thomas Gerbet (tgerbet) , 2022-08-04 11:07
    feat: Handle commits of a push sequentially e408504ea3
    User avatar Joris MASSON (jmasson) , 2022-08-11 15:17
    chore: group related files in the DefaultBranchPush namespace c9e31e68a4
    User avatar Joris MASSON (jmasson) , 2022-08-11 16:15
    feat: send one big event to Tracker instead of small events 753f664b9a
    User avatar Joris MASSON (jmasson) , 2022-08-17 09:42
    feat: add a localized cache for closed artifacts f89741d892
    User avatar Joris MASSON (jmasson) , 2022-08-17 16:04
    feat: Limit handling of closing references to 50 at once cf0fad0bba
    User avatar Joris MASSON (jmasson) , 2022-08-22 09:38
    Display settings

    Follow-ups

    User avatar
    Joris MASSON (jmasson)2022-08-22 16:05

    The bug should be fixed now.

    • Status changed from Under implementation to Closed
    • Connected artifacts
    • Close date set to 2022-08-22