•  
      request #29605 Convert account registration pages to BurningParrot
    Infos
    #29605
    Nicolas Terray (nterray)
    2023-01-16 15:55
    2022-11-10 13:42
    31193
    Details
    Convert account registration pages to BurningParrot

    The registration flow needs some makeover.

    Here is the flow chart of the registration process:

    • pages that need to be converted to BP are highlighted in red with a *
    • pages that are already converted are highlighted in green
    graph TD
        A[Register] --> B{Captcha <br>ok?}
        B -->|no| F
        B -->|yes| D(Create account)
        D --> E{Account <br>created?}
        E -->|no| F[Errors!]
        E -->|yes| G(OIDC link registering account)
        F --> H[Display register form]
        H --> A
        G --> I{User created <br> by site admin?}
        I -->|yes| J{Should send <br>an email?}
        J -->|no| R
        J -->|yes| K(Send email to user with login and pwd #)
        I -->|no| L{sys_user_approval = 0?}
        L -->|no| M[Your account has been created<br>it must be approved by an administrator<br>Once approved clic the confirm button in this email]
        L -->|yes| Q(Send confirmation email #)
        Q --> P{mail accepted <br>for delivery?}
        P -->|yes| O[Your account is created, </br>it now needs to be activated.<br>To do this clic the confirm button in the email]
        P -->|no| S[Error sending <br>confirmation mail]
        K --> R[The user account was created.<br>Please note the login and pwd]
    
        style H fill:#f4f8e9,stroke:#6abf1d,color:#137900
        style R fill:#f4f8e9,stroke:#6abf1d,color:#137900
        style M fill:#f4f8e9,stroke:#6abf1d,color:#137900
        style O fill:#f4f8e9,stroke:#6abf1d,color:#137900
        style S fill:#f4f8e9,stroke:#6abf1d,color:#137900
    

    (# indicates that new pages are needed to better identify errors while delivering the confirmation email)

    UX/UI
    Empty
    Empty
    • [ ] enhancement
    • [x] internal improvement
    Empty
    Stage
    Nicolas Terray (nterray)
    Closed
    2023-01-13
    Attachments
    References
    Referencing request #29605

    Git commit

    tuleap/tuleap/stable

    feat: account creation confirmation to BP (part 2) 1da420ab48
    cleanup: Remove unused presenter c069867137
    feat: Convert register form to BurningParrot 89dedaf522
    Add missing dep to @tuleap/register and adjust to be consistent with the existing core package 4e75da6c04
    refactor: encapsulate form display in an object 8f67b136ce
    refactor: extract account_create in a dedicated object e2b33a14c0
    refactor: Replace Event::BEFORE_USER_REGISTRATION by object 23b4924cc4
    refactor: Replace Event::AFTER_USER_REGISTRATION by object 567a0e5f41
    refactor: Use Neverthrow instead of null + pass-by-reference 81155ff117
    fix: display feedback errors on user registration form 12210c49bb
    refactor: process register form in a dedicated object 2777b9dc20
    refactor: Move register{,_admin}.php to dedicated controllers 4f1e029ac2
    feat: Dedicated error page when confirmation link cannot be sent 363c8d86a9
    refactor: Convert 'before_register' as a Dispatchable 8067e81375
    fix: register.php should be accessible to anonymous 87f86c80d4

    Follow-ups

    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes