Skip to main content

Tuleap Community Edition development and releases are no longer public. You have until September 30th to download packages and sources in Tuleap project. You can contact the team if you need further assistance.

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #29617 Avoid hard crashes when browsing to a Git repository with an invalid reference
    Infos
    #29617
    Thomas Gerbet (tgerbet)
    2022-11-23 17:03
    2022-11-22 13:50
    31252
    Details
    Avoid hard crashes when browsing to a Git repository with an invalid reference

    Accessing /plugins/git/<project_name>/<repo_name>?a=commit&h=invalid_ref should not end up with a 500.

    Trace:

    PHP Fatal error:  Uncaught Error: Call to a member function GetTree() on null in /usr/share/tuleap/plugins/git/include/GitPHP/controller/Controller_Commit.php:101
Stack trace:
#0 /usr/share/tuleap/plugins/git/include/GitPHP/controller/ControllerBase.php(241): Tuleap\Git\GitPHP\Controller_Commit->LoadData()
#1 /usr/share/tuleap/plugins/git/include/GitViews/GitPhpViewer.class.php(98): Tuleap\Git\GitPHP\ControllerBase->Render()
#2 /usr/share/tuleap/plugins/git/include/GitViews/GitPhpViewer.class.php(80): GitViews_GitPhpViewer->displayGitPHP()
#3 /usr/share/tuleap/plugins/git/include/GitViews/GitPhpViewer.class.php(67): GitViews_GitPhpViewer->displayContentWithoutEnclosingDiv()
#4 /usr/share/tuleap/plugins/git/include/GitViews/ShowRepo/Content.class.php(62): GitViews_GitPhpViewer->displayContent()
#5 /usr/share/tuleap/plugins/git/include/Git/GitRepositoryBrowserController.php(168): GitViews_ShowRepo_Content->display()
...
    SCM/Git
    All
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2022-11-23
    Attachments
    Empty
    References
    Referenced by request #29617

    Artifact

    rel #29213 14.3

    Other

    gerrit #27274
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2022-11-22 13:54

    See gerrit #27274.

    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Under implementation to Under review