Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #29968 scroll-to-comment js error when comment is on last line
    Infos
    #29968
    Thomas Gorka (tgorka)
    2022-12-07 12:04
    2022-12-07 10:58
    31596
    Details
    scroll-to-comment js error when comment is on last line

    How to reproduce:

    - In a pull request, go to the changes, and add a comment on the last line of a file

    - Go back to the overview tab

    - Click the link displayed in the header of the comment inside the timeline

    --> The comment is not scrolled into view, and there is an error "There is no line <number> in the document."

    Pull Request
    14.2
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gorka (tgorka)
    Closed
    2022-12-07
    Attachments
    Empty
    References
    Referencing request #29968

    Git commit

    tuleap/tuleap/stable

    request #29968 scroll-to-comment js error when comment is on last line f24d88e362
    User avatar Thomas Gorka (tgorka) , 2022-12-07 11:03
    Merge commit 'refs/changes/05/27405/2' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 661ba83141
    User avatar Nicolas Terray (nterray) , 2022-12-07 12:03
    Referenced by request #29968

    Artifact

    rel #29213 14.3

    Other

    gerrit #27405
    Display settings

    Follow-ups

    User avatar
    Thomas Gorka (tgorka)2022-12-07 11:02

    gerrit #27405 is under review and should close this issue

    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Under implementation to Under review
    User avatar
    Thomas Gorka (tgorka)2022-12-07 10:59
    • Summary
      -scroll-to-comment js error when womment is on last line 
      +scroll-to-comment js error when comment is on last line