•  
      request #39692 Psalm should not ignore new unit tests
    Infos
    #39692
    Joris MASSON (jmasson)
    2024-09-19 10:25
    2024-09-18 12:42
    41319
    Details
    Psalm should not ignore new unit tests

    Previously, we had the following configuration in Psalm, which I thought would still validate Builders in the Trackers unit test folder. It does not work, it turns out everything is still ignored.

    <projectFiles>
      <directory name="plugins/*/tests/unit/" />
      <directory name="plugins/tracker/tests/unit/Builders" />
      <ignoreFiles>
        <directory name="plugins/tracker/tests/unit/"/>
      </ignoreFiles>
    </projectFiles>
    

    We should instead let Psalm validate all unit tests, and selectively ignore each folder/file that has errors. This way, new files will be correctly validated, and old files can be un-ignored surgically. We should also add the existing errors from stubs and builders to the baseline file, so that they will hopefully be corrected gradually.

    Dev tools
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Joris MASSON (jmasson)
    Closed
    2024-09-19
    Attachments
    Empty
    References
    Referencing request #39692

    Follow-ups

    User avatar
    Joris MASSON (jmasson)2024-09-18 15:34
    • Summary
      -Psalm should not ignore new Git and Trackers unit tests 
      +Psalm should not ignore new unit tests 
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    Joris MASSON (jmasson)2024-09-18 12:42
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes