Manuel Vacelet (vaceletm)2024-11-06 09:39 We didn't choose it, it is internal to prosemirror: https://github.com/ProseMirror/prosemirror-commands/blob/master/src/commands.ts#L746 If it's a prose mirror default, chances are that it's expected by end users, let's keep it this way. I guess that the the only behavior that should be addressed is related to the GUI selection.
Nicolas Terray (nterray)2024-11-05 18:13 Regarding Ctrl + Enter I was not aware of it, how did you choose this shortcut ? We didn't choose it, it is internal to prosemirror: https://github.com/ProseMirror/prosemirror-commands/blob/master/src/commands.ts#L746 Should we override it?
Manuel Vacelet (vaceletm)2024-11-05 13:59 Should we mimic the behavior of ckeditor? I don't know, ideally we should align with something that most users would expect. Regarding Ctrl + Enter I was not aware of it, how did you choose this shortcut ? select some preformatted code snippet (👼) + switch to normal text block => keep line breaks and the whole block change to normal text My expectation regarding the selector is that: If I select a part of preformatted text and style it as "text", the selected block should be converted However, if I'm on a line, esp with my carret at the beginning of the line, when I switch my style to "Text" , I don't expect the previous bloc to be converted, I expect that, starting this point, I will have "text"
Nicolas Terray (nterray)2024-11-05 10:14 last edited by: Nicolas Terray (nterray) 2024-11-05 10:14 The default binding to leave a preformatted block is Ctrl+Enter . Should we mimic the behavior of ckeditor? Remove Ctrl+Enter Hit Enter in the middle of preformatted block => stay in preformatted block Hit Shift+Enter at the end of preformatted block => stay in preformatted block Hit Enter at the end of the preformatted block => leave preformatted block to enter a normal text block select some preformatted code snippet (👼) + switch to normal text block => keep line breaks and the whole block change to normal text Status changed from New to Verified