•  
      request #41131 Fix psalm issues
    Infos
    #41131
    Kevin Traini (ktraini)
    2024-12-24 09:56
    2024-12-23 15:15
    42825
    Details
    Fix psalm issues

    psalm.xml and tuleap-baseline.xml ignore way too many errors (we can consider 1 as 1 too many). Goal of this request is to reduce as much as possible the list of ignore (remove the baseline if possible).

    Empty
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Empty
    Under implementation
    Empty
    Attachments
    Empty
    References
    Referencing request #41131

    Git commit

    tuleap/tuleap/stable

    fix: Psalm issues in AdminChartsPresenter a1e1ec95e5
    fix: Psalm issues in AdminScrumPresenter 3ef75d4167
    fix: Psalm issues in AgileDashboard_XMLController 530b188488
    fix: Psalm issuesin AdditionalArtifactActionBuilder 9767780f80
    fix: Psalm issues in several files dfdccd1c6f
    fix: Psalm issues in SubBacklogItemDao 44e4665bd2
    fix: Psalm issues in SubBacklogItemProvider 6e076c499b
    fix: Psalm issues in BacklogItemDao d7a1242c3f
    refactor: Rename all .class.php to .php 5688dac39a
    fix: Psalm issues in IBacklogItem and its implementations dd7b60ab4e
    fix: Psalm issues in AgileDashboard 21cf595b36
    Correct MissingOverrideAttribute in agiledashboard plugin 1338b25b8e
    Correct MissingOverrideAttribute in api_explorer plugin 20cd777d5a
    Correct psalm issues of archiveDeletedPlugin 751282f975
    Correct MissingOverrideAttribute in artidoc plugin c1187f070b
    AgileDashboard/AdminControllerTest must be covered by psalm 17820d0689
    Correct MissingOverrideAttribute in baseline plugin 841d49c6a5
    AgileDashboardServiceHomepageUrlBuilderTest must be covered by psalm c67750ffdb
    Correct MissingOverrideAttribute in botmattermost plugin 5e9d838dfc
    AgileDashboard/ConfigurationManagerTest must be covered by psalm cc65777ad2
    Correct MissingOverrideAttribute in bugzilla_reference plugin bd6c23c06b
    make AgileDashboard_XMLExporter respecting psrs 7b9dc98ff0
    Correct MissingOverrideAttribute in captcha plugin 66d631c95a
    AgileDashboardXMLExporterTest should be covered by psalm 8ec48dfd63
    chore: Remove all MissingOverrideAttributes issues from codebase 38f391b427
    Remove MissingClassConstType from plugin agiledashboard dc872329e4
    Remove MissingClassConstType from plugin artidoc 4e2a7fee59
    tests under AgileDashboard/Tracker && AgileDashboard/Masschange must be covered by psalm 342104e8ab
    make AgileDashboard_XMLImporter respecting psrs f1224727db
    AgileDashboardXMLImporterTest should be covered by psalm 96e34eab36
    AdditionalArtifactActionBuilderTest should be covered by psalm 6018ebfe6c
    Correct MissingClassConstType issues in baseline plugin 723e9c2c23
    Correct MissingClassConstType issues in botmattermost plugin 67cce3dec2
    EventRedirectAfterArtifactCreationOrUpdateHandlerTest must be covered by psalm 4dde622260
    Correct MissingClassConstType issues in botmattermost_agiledashboard plugin cea47ce77d
    RedirectParameterInjector should be covered by psalm d0297e250c
    Correct MissingClassConstType issues in captcha plugin e26faea683
    Correct MissingClassConstType issues in cardwall plugin 8d42284b42
    SubBacklogItemProviderTest && CreateBacklogControllerTest should be covered by psalm 1ea9385c5b
    Correct MissingClassConstType issues in create_test_env plugin 353172b9b5
    Correct MissingClassConstType issues in crosstracker plugin 2a96cd2af8
    Correct MissingClassConstType issues in docman plugin 2edbfaaa68
    Test under ExplicitBacklog must be covered by psalm ae53112e4a
    Correct MissingClassConstType issues in document plugin 882892e395
    Correct MissingClassConstType issues in dynamic_credentials plugin bb022c3d15
    tests under AgileDashboard/FormElement must be covered by psalm 7e81fff5cc
    Correct MissingClassConstType issues in licence_manager plugin 87c0aeb38c
    Correct MissingClassConstType issues in frs plugin 73e5892d8a
    AgileDashboard/HierarchyChecker should repesct psrs 3a58381d42
    Correct MissingClassConstType issues in git plugin 7c38c0f5e5
    Correct MissingClassConstType issues in gitlab plugin 73984dba6f
    Correct MissingClassConstType issues in gitlfs plugin 4089a72ffe
    chore: add User unit test folder to Psalm baseline cf2634fd95
    chore: Add unit and REST test errors to the Psalm baseline 19688265d1
    BacklogItemCollectionFactory should be in its own namespace 95543dcc94
    chore: Fix the last MissingOverrideAttribute issues b2ca0f12d0
    Correct MissingClassConstType issues in graphontrackers plugin 1710e6176d
    fix: Use a separate config for Psalm taint analysis f038b4a9d9
    Correct MissingClassConstType issues in tests of already done plugins 5a55154ffb
    Correct errors of BacklogItemCollectionFactoryTest file 24d19d4ed1
    Correct MissingClassConstType issues in hudson* plugin 91f8dcef03
    Correct MissingClassConstType issues in jira plugin 392fec4049
    Correct plsam error of agiledashboard/test/rest/* files 0f3216a123
    Correct MissingClassConstType issues in kanban plugin daccd0f919
    Correct MissingClassConstType issues in label plugin 7c8b1de5f9
    Correct MissingClassConstType issues in ldap plugin 90970b1337
    Agiledashboard_SequenceIde_Manager should respect psr a25df2bf4f
    Correct MissingClassConstType issues in mediawiki plugin d16b4b7e23
    Correct MissingClassConstType issues in mediawiki_standalone plugin 372d00643d
    Correct errors of SequenceIdManagerTest.php a8455479cc
    Correct MissingClassConstType issues in oauth2_server plugin 7fbc496b3d
    AgileDashboard_Milestone_Backlog_Backlog and AgileDashboard_Milestone_Backlog_BacklogFactory should respect psr b465eb5e5c
    Correct MissingClassConstType issues in openidconnectclient plugin 8731851216
    Move some Agiledashboard/Milestone/Backlog files into milestone/Backlog namespace 53b6e77048
    Move remaining files of Agiledashboard/Milestone/Backlog files into milestone/Backlog namespace 2d181315e4
    Correct MissingClassConstType issues in onlyoffice plugin 1ee1e9ee92
    Correct MissingClassConstType issues in pluginadministration plugin 3894d00674
    Move files of Agiledashboard/Milestone/Pane files into milestone/Pane namespace 3d118db1b9
    Correct MissingClassConstType issues in program_management plugin b8e897e9ce
    fix: Explicitly ignore TQL Parser in psalm analysis bc91243aa6
    Correct MissingClassConstType issues in some plugins 2aa78a1066
    Correct MissingClassConstType issues in pullrequest: plugin 2aa4e8a95e
    Move files of Agiledashboard/Milestone/Pane/details files into milestone/Pane namespace 15a2eaed66
    Correct MissingClassConstType issues in statistics plugin ea00b1e4a0
    Overviewtab should idsplay its content efb46dab54
    Correct MissingClassConstType issues in svn plugin c6a6120ee4
    AgileDashboardPane, AgileDashboardPaneInfoIdentifier, PaneInfoFactory and PlanningMilestonePaneFactory should respect psrs 9f982c11a1
    Correct MissingClassConstType issues in taskboard plugin ea3cb64f0e
    Correct MissingClassConstType issues in some plugin 40bd820257
    move Agiledashboard/milestone/Pane/Planning into Milestone/pane/Planning fa0c3b934b
    Correct MissingClassConstType issues in tracker plugin fdfac3b4df
    Correct MissingClassConstType issues in remaining plugins 80d4217fb1
    Remove MissingClassConstType in src/common folder 809bdc884f
    Remove the last remaining MissingClassConstType edd62e35d7
    Move AgileDashboard/Milestone/Pane/TopPlanning into Milestone/Pane/TopPlanning 73f14c6182
    Move AgileDashboard/Artifact into /Artifact 6daafa3677
    Move Agiledashboard/BacklogItem into BacklogItem and respect psr d1250fa57e
    Move Agieldashboard/BreadCrumDropdown into BreadCrumDropdown 82cc7137cd
    Move Agiledashboard/Event into Event 971d46715e
    Move AgileDashboard/ExplicitBacklog into ExplicitBacklog 086df30797
    Move some elments from Agiledashboard/FormElement/Burnup to /FormElement/Burnup 96940f3032
    Event cssFile should no longer use the deprecated `addHook` method b3a8d99de8

    Follow-ups

    User avatar
    Kevin Traini (ktraini)2024-12-23 15:16
    • Original Submission
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes