Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #45252 Broken SeatManagement expiration feedback test
    Actions
    Infos
    #45252
    Kevin Traini (ktraini)
    2025-10-29 15:52
    2025-10-29 14:42
    46970
    Details
    Broken SeatManagement expiration feedback test

    FeedbackBuilderTest::testAtExpirationDateItShouldAddFeedbackForSiteAdmin is broken due to a problem of time diff.

    The easiest way to fix this is to pass the current datetime to FeedbackBuilder through Psr\Clock\ClockInterface. This way in production code we use the real date and in tests we use a frozen clock with a fixed date

    Empty
    Empty
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Kevin Traini (ktraini)
    Closed
    2025-10-29
    Attachments
    Empty
    References
    Referencing request #45252

    Git commit

    tuleap/tuleap/stable

    fix: request #45252 Broken SeatManagement expiration feedback test 84c74296b4
    User avatar Kevin Traini (ktraini) , 2025-10-29 14:41
    Merge commit 'refs/changes/65/36065/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 277fa5a947
    User avatar Clarisse Deschamps (cdeschamps) , 2025-10-29 15:49
    Display settings

    Follow-ups