done at https://tuleap.net/plugins/git/tuleap/deps/tuleap/gitweb-tuleap?p=deps%2Ftuleap%2Fgitweb-tuleap.git&a=commitdiff&h=969e619bc95cce9276c623c592d0cc0e5f96d4a2

thanks.

Hello Nouha,

I think it's best if I don't review this change. I'm passing it to someone who knows the context and has already a setup.

Ah, I see. Different project !

Where on my system do I clone the git project to?

I am sorry but it has nothing to do with my contrib!!
I don't even use codendi sources.
You have to pull git project http://gerrit.tuleap.net/#/admin/projects/git then gitweb-tuleap branch or co my change, if you want to see the code changes.

Hi,

I have checked-out your change and many things seems odd.

The contents of /usr/share/codendi/ looks nothing like it normally would. I get the impression that there are a lot of cached files that shouldn't be there and that other things have gone missing. For example, running

service codendi restart
tells me
cannot stat `/usr/share/codendi/src/utils/cron.d/codendi': No such file or directory

And I agree. `/usr/share/codendi/src/utils/cron.d/ is not present when I checkout.


Also, I see that there's a patch file that updates the README. Am I supposed to apply the patch? Why isn't the README changed and pushed into the commit directly?



Here's a copy of /usr/share/codendi contents after I checkout:

-bash-4.1# ls /usr/share/codendi/
abspath.c environment.c log-tree.c sh-i18n--envsubst.c
aclocal.m4 exec_cmd.c log-tree.h shortlog.h
advice.c exec_cmd.h mailmap.c show-index.c
advice.h fast-import.c mailmap.h sideband.c
alias.c fetch-pack.h Makefile sideband.h
alloc.c fixup-builtins match-trees.c sigchain.c
archive.c fmt-merge-msg.h merge-file.c sigchain.h
archive.h fsck.c merge-file.h src
archive-tar.c fsck.h merge-recursive.c strbuf.c
archive-zip.c generate-cmdlist.sh merge-recursive.h strbuf.h
argv-array.c gettext.c mergesort.c streaming.c
argv-array.h gettext.h mergesort.h streaming.h
attr.c git-add--interactive.perl mergetools string-list.c
attr.h git-am.sh name-hash.c string-list.h
base85.c git-archimport.perl nbproject submodule.c
bisect.c git-bisect.sh notes.c submodule.h
bisect.h git.c notes-cache.c symlinks.c
blob.c git-compat-util.h notes-cache.h t
blob.h git-cvsexportcommit.perl notes.h tag.c
block-sha1 git-cvsimport.perl notes-merge.c tag.h
branch.c git-cvsserver.perl notes-merge.h tar.h
branch.h git-difftool--helper.sh object.c templates
builtin git-difftool.perl object.h test-chmtime.c
builtin.h git-filter-branch.sh pack-check.c test-ctype.c
bulk-checkin.c git-gui pack.h test-date.c
bulk-checkin.h git-instaweb.sh pack-refs.c test-delta.c
bundle.c gitk-git pack-refs.h test-dump-cache-tree.c
bundle.h git-lost-found.sh pack-revindex.c test-genrandom.c
cache.h git-merge-octopus.sh pack-revindex.h test-index-version.c
cache-tree.c git-merge-one-file.sh pack-write.c test-line-buffer.c
cache-tree.h git-merge-resolve.sh pager.c test-match-trees.c
check_bindir git-mergetool--lib.sh parse-options.c test-mergesort.c
check-builtins.sh git-mergetool.sh parse-options-cb.c test-mktemp.c
check-racy.c git-p4.py parse-options.h test-parse-options.c
color.c git-parse-remote.sh patch-delta.c test-path-utils.c
color.h git-pull.sh patch-ids.c test-regex.c
column.c git-quiltimport.sh patch-ids.h test-revision-walking.c
column.h git-rebase--am.sh path.c test-run-command.c
combine-diff.c git-rebase--interactive.sh perl test-scrap-cache-tree.c
command-list.txt git-rebase--merge.sh pkt-line.c test-sha1.c
commit.c git-rebase.sh pkt-line.h test-sha1.sh
commit.h git-relink.perl plugins test-sigchain.c
compat git_remote_helpers po test-subprocess.c
composer.json git-remote-testgit.py ppc test-svn-fe.c
composer.lock git-repack.sh preload-index.c thread-utils.c
composer.phar git-request-pull.sh pretty.c thread-utils.h
config.c git-send-email.perl progress.c trace.c
config.mak.in git-sh-i18n.sh progress.h transport.c
configure.ac git-sh-setup.sh prompt.c transport.h
connect.c git.spec.in prompt.h transport-helper.c
connected.c git-stash.sh quote.c tree.c
connected.h git-submodule.sh quote.h tree-diff.c
contrib git-svn.perl reachable.c tree.h
convert.c GIT-VERSION-GEN reachable.h tree-walk.c
convert.h gitweb read-cache.c tree-walk.h
copy.c git-web--browse.sh README unimplemented.sh
COPYING gpg-interface.c reflog-walk.c unix-socket.c
credential.c gpg-interface.h reflog-walk.h unix-socket.h
credential-cache.c graph.c refs.c unpack-trees.c
credential-cache--daemon.c graph.h refs.h unpack-trees.h
credential.h grep.c RelNotes upload-pack.c
credential-store.c grep.h remote.c url.c
csum-file.c hash.c remote-curl.c url.h
csum-file.h hash.h remote.h usage.c
ctype.c help.c replace_object.c userdiff.c
daemon.c help.h rerere.c userdiff.h
date.c hex.c rerere.h utf8.c
decorate.c http-backend.c resolve-undo.c utf8.h
decorate.h http.c resolve-undo.h varint.c
delta.h http-fetch.c revision.c varint.h
diff.c http.h revision.h vcs-svn
diffcore-break.c http-push.c run-command.c vendor
diffcore-delta.c http-walker.c run-command.h version.c
diffcore.h ident.c send-pack.h version.h
diffcore-order.c imap-send.c sequencer.c walker.c
diffcore-pickaxe.c INSTALL sequencer.h walker.h
diffcore-rename.c kwset.c server-info.c wrap-for-bin.sh
diff-delta.c kwset.h setup.c wrapper.c
diff.h levenshtein.c sha1-array.c write_or_die.c
diff-lib.c levenshtein.h sha1-array.h ws.c
diff-no-index.c LGPL-2.1 sha1_file.c wt-status.c
dir.c list-objects.c sha1-lookup.c wt-status.h
dir.h list-objects.h sha1-lookup.h xdiff
Documentation ll-merge.c sha1_name.c xdiff-interface.c
editor.c ll-merge.h shallow.c xdiff-interface.h
entry.c lockfile.c shell.c zlib.c

I just posted new patchsets for the 2 changes.
thnak you for your review

Thanks.

I am really having problems on getting started with gitweb with Tuleap. I have asked others (Manuel) on how to install but no one seems to know how to get it working. Is there documentation somewhere? Other than to checkout your branch or installing the plugin gitweb-tuleap, are there any other things that need to be installed? Would it be possible to add a section on how to activate gitweb for Tuleap at the end of this page? https://tuleap-documentation.readthedocs.org/en/latest/administration-guide/howto.html

For Info, I did find the README and INSTALL files. However, when running "make gitweb" and "make install-gitweb" I get errors of the form

curl-config: command not found

I do have curl and libcurl installed so I'm guessing there's some other package that needs to be pulled but I can't find which one.

Hi,

It depends on your project list path for the gitolite repositories.

You should modify it on /etc/gitweb.conf. For me it is on :
our $projects_list = "/usr/com/gitolite/projects.list";

Dylan will continue your code review.

Regards,
-- Martin

Any update, please?

We are going to review it.

Any update, please?

review:
gerrit #2905
gerrit #2906 for the packaging