Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

  •  
     
    story #8372 see follow-up comments in modal
Actions
Summary
scrum user
see follow-up comments in modal
I can get a quick look to what are the last updates on the subject
  • Need to replace bootstrap modale by a custom, larger one (see attached mock-up)
  • IE9 minimal compatibility (should work even not perfect)
  • 2 scrollbars (artifact, comments)
  • First step: only changeset + comments (diff & field changes are not displayed)

Be careful with images (might break layout) and performances of various REST routes (esp. regarding DOM blocking)

IMPORTANT: Regarding attachment / mock-up:

The artifact will not be in "read mode", it will still be in edit mode with all fields inline. Modification of the rendering of the artifact in the modal can be covered in a dedicated story

By Manuel Vacelet (vaceletm)
(357 kB)
tuleap-new-artifact-modal-big.png
Patricia Carrasco (pcar)
Status
Empty
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#8372
Manuel Vacelet (vaceletm)
2015-10-12 10:58
2015-08-25 15:55
4697

References
Artifact links
Empty
Referencing story #8372

Artifact Tracker v5

epic #7856 Artifact modal with angular
story #8373 see fields changes in modal follow-up comments
rel #8395 8.7

Git commit

tuleap/tuleap/stable

Merge commit 'refs/changes/93/4493/6' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 898b1fef8e
User avatar Nicolas Terray (nterray) , 2015-09-23 13:21
story #8372: Have the modal inherit colors from user theme 38a7fbe244
User avatar Joris MASSON (jmasson) , 2015-09-23 11:38
Merge commit 'refs/changes/16/4516/6' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 02863b1083
User avatar Yannis ROSSETTO (rossettoy) , 2015-09-28 14:57
story #8372: update /artifacts/:id/changesets and add /users/:id/preferences c6efe4fc60
User avatar Benjamin Dauton (bdauton_enalean) , 2015-09-28 14:24
Merge commit 'refs/changes/23/4523/6' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 9a26b2d74b
User avatar Yannis ROSSETTO (rossettoy) , 2015-09-29 15:34
story #8372: see followups comments in PV2 and Kanban modal 3153c86a23
User avatar Benjamin Dauton (bdauton_enalean) , 2015-09-29 15:22
Merge commit 'refs/changes/47/4547/1' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD d3d67fe2c2
User avatar Yannis ROSSETTO (rossettoy) , 2015-10-02 17:24
story #8372: Fix wrong submitted_by_details value in REST route b02e1dc6ac
User avatar Benjamin Dauton (bdauton_enalean) , 2015-10-02 16:54
Display settings

Follow-ups

User avatar
Manuel Vacelet (vaceletm)2015-08-28 08:46

The user should only be interested is seeing previous comments and have the ability to enter his/her own comments in the modal view. The change set is not needed in this modal view.

Ok so this is exactly the scope of this story.

However, as there is a change (regarding first modal) we will add a warning/info message that tells that some informations are not displayed with a link to the artifact view.

"The artifact will not be in "read mode", it will still be in edit mode with all fields inline. Modification of the rendering of the artifact in the modal can be covered in a dedicated story."

In the mock-up you can see that the fields are in "read" by default ("So that" field for instance) and there is a need to click on the edit icon to toggle the field for edition ("I want to" field) as it's done in artifact view.

This read/edit toggle will not be part of this story, fields will all be in edit mode (if you can edit them) as it's done in current modals.

We attached this mock-up to present the overall design (bigger modal, display of the follow-ups, scollbars, ...)

Is that more clear ?

User avatar
Patricia Carrasco (pcar)2015-08-27 20:25
Hi Manuel,

The user should only be interested is seeing previous comments and have the ability to enter his/her own comments in the modal view. The change set is not needed in this modal view.

Not sure we understand what you mean by:
"The artifact will not be in "read mode", it will still be in edit mode with all fields inline. Modification of the rendering of the artifact in the modal can be covered in a dedicated story."

Can you please elaborate?
User avatar
Manuel Vacelet (vaceletm)2015-08-27 17:22
Hi Patricia,

Tell us if the story corresponds to your needs ?
  • CC list set to Patricia Carrasco (pcar)
User avatar
Manuel Vacelet (vaceletm)2015-08-25 15:55
  • I want to
    -see follow-up comments in modale 
    +see follow-up comments in modal 
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes