Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      story #9213 timeout git operations in push email
    Actions
    Summary
    site admin
    timeout git operations in push email

    I don't get the server overloaded by git diff that takes ages

    • Each git operation in post-receive-email is verified
    • When relevant (e.g. git diff) a "timout 5" is added in front of the operation. The 2 identified operations are
      • generation of "Summary of changes", impacted by very large diff or diff including a large file
      • generation of "Log", impacted by very large history (for instance import of linux kernel) or log with a very large file.
    • The error case (timeout) is properly handled with a message that indicates that the operation took too much time and was aborted.
    • When we reach a timeout, a mail is sent to site admin to warn about a potential mis-use of git.
    Empty
    Nouha Terzi (terzino), Denis PILAT (denis_pilat), Ahmed HOSNI (hosniah), Thomas Gerbet (tgerbet)
    Status
    Empty
    Done
    Development
    • [ ] Does it involves User Interface? 
    • [ ] Are there any mockups?
    • [ ] Are permissions checked?
    • [ ] Does it need Javascript development?
    • [ ] Does it need a forge upgrade bucket?
    • [ ] Does it need to execute things in system events?
    • [ ] Does it impact project creation (templates)?
    • [ ] Is it exploratory?
    Empty
    Details
    #9213
    Manuel Vacelet (vaceletm)
    2016-07-19 14:58
    2016-06-01 10:20
    9467

    References
    Artifact links
    Empty
    Referencing story #9213

    Artifact Tracker v5

    rel #9210 8.17

    Git commit

    tuleap/tuleap/stable

    Add a timeout to expensive operations in the post-receive-email Git hook 793859863e
    User avatar Thomas Gerbet (tgerbet) , 2016-07-18 15:54
    Notify site admin if a potential mis-use of Git is detected. e8c7d305b0
    User avatar Thomas Gerbet (tgerbet) , 2016-07-19 13:49
    Referenced by story #9213

    Other

    gerrit #6172
    gerrit #6200
    Display settings

    Follow-ups

    User avatar
    Manuel Vacelet (vaceletm)2016-07-18 16:37

    gerrit #6172 integrated in 8.16.99.70.

    For @terzino and @denis_pilat , I precised in acceptance criteria the 2 operations that we found impacted by "large / uncontrolled stuff".

     

     

    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    User avatar
    Thomas Gerbet (tgerbet)2016-07-13 09:55
    • So that
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Acceptance criteria
      Something went wrong, the follow up content couldn't be loaded
      Only formatting have been changed, you should switch to markup to see the changes
    • Status changed from Ready (stalled) to On going
    • CC list Thomas Gerbet (tgerbet) added