Skip to main content

Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

    •  
      request #12877 Workflow transition permission should not fall back to project_members if no value is selected
    Actions
    Infos
    #12877
    Martin GOYOT (goyotm)
    2019-01-30 09:53
    2019-01-29 16:56
    13734
    Details
    Workflow transition permission should not fall back to project_members if no value is selected
    Right now, if you go into the workflow UI go to the details of a transition, remove the authorized group/groups and submit, project_members is selected by default.

    It may be a good idea not to do this but instead dismiss the submission and add a warning telling the user that this value is mandatory.
    Trackers
    development
    Empty
    • [ ] enhancement
    • [ ] internal improvement
    Empty
    Stage
    Thomas Gerbet (tgerbet)
    Closed
    2019-01-30
    Attachments
    Artifact links

    Releases

    Fixed in

    Artifact ID Project Tracker Summary Status Last Update Date Submitted By Assigned to
    rel #12559 Tuleap Releases 10.10 Delivered 2019-01-31 15:00 Manuel Vacelet (vaceletm)
    Empty
    References
    Referencing request #12877

    Git commit

    tuleap/tuleap/stable

    Merge commit 'refs/changes/60/13860/4' of ssh://gerrit.tuleap.net:29418/tuleap into HEAD 3cb3a52d47
    User avatar Marie Ange Garnier (marieange) , 2019-01-30 09:53
    request #12877: Workflow transition permission should not fall back to project_members if no value is selected 67a7e0f7d0
    User avatar Thomas Gerbet (tgerbet) , 2019-01-29 19:30
    Display settings

    Follow-ups

    User avatar
    Thomas Gerbet (tgerbet)2019-01-29 17:14
    I'm not quite sure to understand what kind of trade of has been done here but IMHO git #tuleap/stable/94f585599a812e80ec9778f88a68cee9e94fa6a3 should not have been merged as is.

    This permission can be used to enforce that a certain people validate a specific change of state and as such is fully part of the traceability and audit capabilities of the trackers.
    Setting a default to a possibly quite large group of people is not sane nor acceptable.


    Yes, a fatal error was far from ideal too but at least the audit capabilities were not weakened.
    • Status changed from New to Under implementation
    • Assigned to changed from None to Thomas Gerbet (tgerbet)
    • Reported in version set to development
    • Is an Enhancement or an internal improvement? cleared values: enhancement