•  
     
    story #24970 [modal] select type for links
Summary
Empty
[modal] select type for links
Empty
  • New links can have a type
  • Existing links type can be changed
    • Expect for _mirrored_milestone system links that are neither editable nor deletable (cf request #30358)

In both case, types are presented in both "Foward" and "Reverse" fashion (ie. I can select either "is child of" or "is parent of") the information is sent to the backend that transparently do the linking in the expected way. That is to say, if I choose a "Reverse" label, the target artifact will be updated with a link to the current artifact.

Note: the field should not propose to have several parents for an artifact (special behaviour of _is_child).

Link type renaming

Link types are source of confusion for (new) users, esp. the fact that _is_child shows "Child".

Given something like A -_is_child-> B. From a technical standpoint it means

  • A is an artifact
  • B is another artifact
  • A has a link toward B with type _is_child
  • therefore A is parent of B

However, the labels just say the reverse. The forward label for _is_child is "Child" while the reverse label is "Parent".

Let's add A -_covered_by-> C:

  • A is an artifact
  • C is another artifact
  • A has a link toward C with type _covered_by
  • therefore A is covered by C

When displayed in the modal, if using the appropriate label, with the setup described upper, we have:

  • Child: B
  • Covered by: C

As shown in the mock-ups, the people are expecting a sentence with a verb to better grasp the relation ship, like

  • (A) is parent of B
  • (A) is covered by C

Modifications:

  • For "_covered_by", the change is rather trivial, the labels just have to be updated "Covered by" becomes "is covered by" (reverse doesn't change "covers".
  • For "_is_child", the change is more impactful because it's actually the type name that is wrong because A _is_child B should not mean that B is the child of A ! Therefore the proposal is to:
    • Do only the modification in the artifact modal labels and to hardcode the values in front end
    • Link type names are not modified
    • Artifact view is not modified (the fact that the type is shown after the link make it less source of error)

Figma

Link to figma with comments

Empty
Empty
Status
Trackers
Done
Development
  • [ ] Does it involves User Interface? 
  • [ ] Are there any mockups?
  • [ ] Are permissions checked?
  • [ ] Does it need Javascript development?
  • [ ] Does it need a forge upgrade bucket?
  • [ ] Does it need to execute things in system events?
  • [ ] Does it impact project creation (templates)?
  • [ ] Is it exploratory?
Empty
Details
#24970
Manuel Vacelet (vaceletm)
2023-03-24 14:26
2022-01-04 17:44
28712

References

Follow-ups

User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes
User avatar
  • Acceptance criteria
    Something went wrong, the follow up content couldn't be loaded
    Only formatting have been changed, you should switch to markup to see the changes